feat: initial changes (not fixed yet)

fix: Favicon not showing

package.json

@@ -1,6 +1,6 @@
 {
   "name": "betterseqtaplus",
-  "version": "3.4.11",
+  "version": "3.4.13",
   "type": "module",
   "description": "Enhance SEQTA Learn's usability and aesthetics! A fork of BetterSEQTA to continue development add add heaps more features!",
   "browserslist": "> 0.5%, last 2 versions, not dead",
@@ -47,7 +47,7 @@
     "mime-types": "^3.0.1",
     "prettier": "^3.5.3",
     "process": "^0.11.10",
-    "publish-browser-extension": "^3.0.1",
+    "publish-browser-extension": "^4.0.0",
     "sass": "^1.85.1",
     "sass-loader": "^16.0.5",
     "semver": "^7.7.1",

src/SEQTA.ts

@@ -50,10 +50,12 @@ async function init() {
     documentLoadStyle.textContent = documentLoadCSS;
     document.head.appendChild(documentLoadStyle);
 
-    const icon = document.querySelector(
+    const icons =
-      'link[rel*="icon"]',
+      document.querySelectorAll<HTMLLinkElement>('link[rel*="icon"]');
-    )! as HTMLLinkElement;
+
-    icon.href = icon48; // Change the icon
+    icons.forEach((link) => {
+      link.href = icon48;
+    });
 
     try {
       await initializeSettingsState();

src/background.ts

@@ -108,7 +108,7 @@ function getDefaultValues(): SettingsState {
     originalSelectedColor: "",
     DarkMode: true,
     animations: !isLowEndDevice,
-    assessmentsAverage: true,
+    assessmentsAverage: false,
     defaultPage: "home",
     shortcuts: [
       {

src/css/injected.scss

@@ -57,7 +57,8 @@ select {
   transition: 200ms;
   background: var(--auto-background) !important;
 }
-* {
+:root * {
+  font-family: Rubik, sans-serif !important;
   --theme-fg-parts: white;
 }
 .extension-editor {
@@ -823,8 +824,8 @@ div > ol:has(.uiFileHandlerWrapper) {
 [aria-labelledby="lixycoxs-tab-1"] [minlength="0"] {
   min-height: 128px !important;
 }
-.student #menu > ul::before {
+body.student #menu > ul::before {
-  background-image: var(--betterseqta-logo);
+  background-image: var(--betterseqta-logo) !important;
   position: -webkit-sticky;
   position: sticky;
   top: 0;
@@ -1043,8 +1044,8 @@ html.transparencyEffects
   display: none;
 }
 #title {
-  background: var(--background-primary);
+  background: var(--background-primary) !important;
-  color: var(--text-primary);
+  color: var(--text-primary) !important;
   display: flex;
   justify-content: space-between;
   padding-right: 56px !important;
@@ -2206,7 +2207,6 @@ div.bar.flat {
       border-radius: 12px !important;
       border: none !important;
       box-shadow: none !important;
-      color: #fff !important;
       padding: 16px !important;
       margin: 0 !important;
       height: 100% !important;
@@ -2214,6 +2214,7 @@ div.bar.flat {
       display: flex !important;
       align-items: flex-start !important;
       overflow: hidden !important;
+      color: var(--text-primary) !important;
     }
   }
 
@@ -3357,7 +3358,6 @@ div.day-empty {
   flex-direction: column;
   color: var(--text-primary);
   transform-origin: center center;
-
 }
 .whatsnewTextContainer.privacyStatement p {
   margin-bottom: 1.5ex;
@@ -3367,7 +3367,7 @@ div.day-empty {
   }
 }
 .whatsnewTextContainer.privacyStatement a {
-  background: rgba(184, 184, 184, 0.1); 
+  background: rgba(184, 184, 184, 0.1);
   border-radius: 0.5rem;
   margin-left: 0.25rem;
   padding: 2px 4px;
@@ -3436,7 +3436,6 @@ div.day-empty {
   font-size: 0.75rem;
   font-weight: 500;
   color: #9a3412;
-  background-color: #ffedd569;
   border-radius: 9999px;
   border: 1px solid rgba(253, 186, 140, 0.3);
   background-color: #ffedd5;
@@ -3813,7 +3812,7 @@ div.day-empty {
     font-size: 20px !important; // Nice middle ground - not too big, not too small
     font-weight: 600 !important;
     color: var(--text-primary) !important;
-    margin: 0 0 12px 0 !important;
+    margin: 0 0 12px !important;
     line-height: 1.3 !important;
     flex-shrink: 0;
   }
@@ -3925,7 +3924,6 @@ button.notice-close-btn {
   align-items: center;
   justify-content: center;
   cursor: pointer;
-  font-size: 18px;
   color: var(--text-primary);
   transition: all 0.2s ease !important;
   flex-shrink: 0;
@@ -3983,13 +3981,13 @@ button.notice-close-btn {
   font-size: 24px;
   font-weight: 600;
   color: var(--text-primary);
-  margin: 16px 20px 20px 20px;
+  margin: 16px 20px 20px;
   line-height: 1.3;
   flex-shrink: 0;
 }
 
 .notice-modal-body {
-  padding: 0 20px 20px 20px;
+  padding: 0 20px 20px;
   font-size: 15px;
   line-height: 1.6;
   color: var(--text-secondary);
@@ -4070,11 +4068,11 @@ button.notice-close-btn {
 
   .notice-modal-title {
     font-size: 20px;
-    margin: 12px 16px 16px 16px;
+    margin: 12px 16px 16px;
   }
 
   .notice-modal-body {
-    padding: 0 16px 16px 16px;
+    padding: 0 16px 16px;
   }
 
   .notice-card {

src/manifests/firefox.ts

@@ -14,7 +14,7 @@ const updatedFirefoxManifest = {
   },
   browser_specific_settings: {
     gecko: {
-      id: pkg.author.email,
+      id: "betterseqta@betterseqta.com",
     },
   },
 };

src/plugins/built-in/profilePicture/styles.css

@@ -8,12 +8,16 @@
   object-fit: cover;
   z-index: 4;
   box-shadow: 0 0 0 3px #000000;
+  transition: box-shadow 0.05s ease-in-out;
 }
 
 .dark .userInfoImg {
   box-shadow: 0 0 0 3px #ffffff;
+  transition: box-shadow 0.05s ease-in-out;
 }
 
-.userInfosvgdiv {
+@media (prefers-reduced-motion: reduce) {
-  filter: invert(0) !important;
+  .userInfoImg {
-}
+    transition: none !important;
+  }
+}

src/plugins/built-in/themes/theme-manager.ts

@@ -147,14 +147,21 @@ export class ThemeManager {
   public async initialize(): Promise<void> {
     console.debug("[ThemeManager] Starting initialization");
     try {
-      // Check if theme creator was open during reload
+      const neumorphicThemeId = "9a9786d1-b5fc-4a91-8c7a-f8bf7f7679ad";
+      const migrationCSS = "#title {\nbackground: transparent !important;\n}";
+      
+      const theme = (await localforage.getItem(neumorphicThemeId)) as CustomTheme | null;
+      if (theme && theme.CustomCSS && !theme.CustomCSS.includes("#title {\nbackground: transparent !important;\n}")) {
+        theme.CustomCSS = theme.CustomCSS + "\n" + migrationCSS;
+        await localforage.setItem(neumorphicThemeId, theme);
+      }
+
       const themeCreatorOpen = localStorage.getItem("themeCreatorOpen");
       if (themeCreatorOpen === "true") {
         console.debug(
           "[ThemeManager] Theme creator was open, clearing preview state",
         );
         this.clearPreview();
-        // Clean up the flag
         localStorage.removeItem("themeCreatorOpen");
       }
 

src/plugins/monofile.ts

@@ -27,6 +27,7 @@ import { OpenWhatsNewPopup } from "@/seqta/utils/Openers/OpenWhatsNewPopup";
 import { showPrivacyNotification } from "@/seqta/utils/Openers/OpenPrivacyNotification";
 
 import { updateTimetableTimes } from "@/seqta/utils/updateTimetableTimes";
+import { fixTimetableColours } from "@/seqta/utils/fixTimetableColours";
 
 // JSON content
 import MenuitemSVGKey from "@/seqta/content/MenuItemSVGKey.json";
@@ -99,7 +100,11 @@ export async function finishLoad() {
     await showPrivacyNotification();
   }
 
-  if (settingsState.justupdated && !document.getElementById("whatsnewbk") && !document.getElementById("privacy-notification")) {
+  if (
+    settingsState.justupdated &&
+    !document.getElementById("whatsnewbk") &&
+    !document.getElementById("privacy-notification")
+  ) {
     OpenWhatsNewPopup();
   }
 }
@@ -257,6 +262,7 @@ async function LoadPageElements(): Promise<void> {
     },
     async () => {
       await updateTimetableTimes();
+      await fixTimetableColours();
     },
   );
 

src/seqta/ui/AddBetterSEQTAElements.ts

@@ -173,28 +173,35 @@ async function updateStudentInfo(students: any) {
     );
   });
 
-  let houseelement1 = document.getElementsByClassName("userInfohouse")[0];
+  const houseelement = document.getElementsByClassName("userInfohouse")[0] as HTMLElement;
-  const houseelement = houseelement1 as HTMLElement;
+
+  // Fallback to N/A
+  let text = 'N/A';
+  const student = students[index] ?? {};
+
+  // If student has a house, prefer to show year + house. If no year, only show house.
+  if (student.house) {
+    text = `${student.year ?? ""}${student.house}`;
+
+    // If house_colour exists, compute colour
+    if (student.house_colour) {
+      houseelement.style.background = student.house_colour;
 
-  if (students[index]?.house) {
-    if (students[index]?.house_colour) {
-      houseelement.style.background = students[index].house_colour;
       try {
-        let colorresult = GetThresholdOfColor(students[index]?.house_colour);
+        const colorresult = GetThresholdOfColor(student.house_colour);
         houseelement.style.color =
           colorresult && colorresult > 300 ? "black" : "white";
-        houseelement.innerText = students[index].year + students[index].house;
+
-      } catch (error) {
+      } catch (err) {
-        houseelement.innerText = students[index].house;
+        // Colour calculation failed, no text colour set
       }
     }
-  } else {
+  } else if (student.year) {
-    try {
+    // No house, only year will be shown
-      houseelement.innerText = students[index].year;
+    text = student.year;
-    } catch (err) {
-      houseelement.innerText = "N/A";
-    }
   }
+
+  houseelement.innerText = text;
 }
 
 function createNewsButton(fragment: DocumentFragment, menu: HTMLElement) {

src/seqta/utils/Openers/OpenWhatsNewPopup.ts

@@ -32,6 +32,19 @@ export function OpenWhatsNewPopup() {
   const text = stringToHTML(/* html */ `
     <div class="whatsnewTextContainer" style="height: 50%;overflow-y: auto;">
 
+      <h1>3.4.13 - Bug Fixes & Styling Improvements</h1>
+      <li>Fixed house/year box hard failing when house_colour does not exist</li>
+      <li>Fixed message of the day being unreadable in light mode</li>
+      <li>Fixed global font styling issues due to SEQTA updates</li>
+      <li>Fixed styling issues with title bar and other elements</li>
+      <li>Other minor bug fixes and improvements</li>
+
+      <h1>3.4.12 - Privacy Updates & Bug Fixes</h1>
+      <li>Added privacy statement</li>
+      <li>Added disclaimer modal to assessment averages switch</li>
+      <li>Improved popup management system</li>
+      <li>Other minor bug fixes and improvements</li>
+
       <h1>3.4.11 - New Features & Bug Fixes</h1>
       <li>Added Background Music plugin</li>
       <li>Added empty state for assessments on homepage</li>

src/seqta/utils/fixTimetableColours.ts

@@ -0,0 +1,126 @@
+import { waitForElm } from "./waitForElm";
+
+let timetableObserver: MutationObserver | null = null;
+let isOnTimetablePage = false;
+let isInitialized = false;
+let abortController: AbortController | null = null;
+
+let lastSnapshot: String = "";
+
+function checkIfOnTimetablePage(): boolean {
+  return window.location.hash.includes("page=/timetable");
+}
+
+function startTimetableMonitoring(): void {
+  if (timetableObserver) return;
+
+  const timetablePage = document.querySelector(".timetablepage");
+  if (!timetablePage) return;
+
+  lastSnapshot = Array.from(
+    timetablePage.querySelectorAll("*"),
+    (el) => getComputedStyle(el).color,
+  ).join("|");
+
+  // Create observer for timetable content changes
+  timetableObserver = new MutationObserver((mutations) => {
+    const snapshot = Array.from(
+      timetablePage.querySelectorAll("*"),
+      (el) => getComputedStyle(el).color,
+    ).join("|");
+
+    if (snapshot !== lastSnapshot) {
+      // implement colour fix code here
+      lastSnapshot = snapshot;
+    }
+  });
+
+  timetableObserver.observe(timetablePage, {
+    childList: true,
+    subtree: true,
+  });
+}
+
+function handleUrlChange(): void {
+  const currentlyOnTimetable = checkIfOnTimetablePage();
+
+  if (currentlyOnTimetable !== isOnTimetablePage) {
+    isOnTimetablePage = currentlyOnTimetable;
+
+    if (isOnTimetablePage) {
+      // Wait a bit for the page to load, then start monitoring
+      setTimeout(() => {
+        startTimetableMonitoring();
+      }, 100);
+    } else {
+      stopTimetableMonitoring();
+    }
+  } else if (isOnTimetablePage) {
+  }
+}
+
+function startUrlMonitoring(): void {
+  if (isInitialized) return;
+  isInitialized = true;
+
+  // Create abort controller for cleanup
+  abortController = new AbortController();
+  const signal = abortController.signal;
+
+  // Listen for hash changes (more efficient than polling)
+  window.addEventListener("hashchange", handleUrlChange, { signal });
+  window.addEventListener("popstate", handleUrlChange, { signal });
+
+  // Initial check
+  handleUrlChange();
+}
+
+function stopTimetableMonitoring(): void {
+  if (timetableObserver) {
+    timetableObserver.disconnect();
+    timetableObserver = null;
+  }
+}
+
+function stopUrlMonitoring(): void {
+  if (!isInitialized) return;
+  isInitialized = false;
+
+  // Abort all event listeners at once
+  if (abortController) {
+    abortController.abort();
+    abortController = null;
+  }
+
+  stopTimetableMonitoring();
+}
+
+// Initialize monitoring on page load
+if (typeof window !== "undefined") {
+  // Start URL monitoring immediately
+  startUrlMonitoring();
+}
+
+export async function fixTimetableColours(): Promise<void> {
+  const timetablePage = document.querySelector(".timetablepage");
+  if (!timetablePage) return;
+
+  // Wait for time elements to exist if page is still loading
+  try {
+    await waitForElm(".timetablepage .time", true, 10);
+  } catch {
+    return;
+  }
+
+  // Start continuous monitoring when this function is called
+  isOnTimetablePage = checkIfOnTimetablePage();
+  if (isOnTimetablePage) {
+    startTimetableMonitoring();
+    startUrlMonitoring();
+  }
+}
+
+// Cleanup function for when the module is unloaded
+export function cleanup(): void {
+  stopUrlMonitoring();
+}