From f985f9445f7b2e6d893f5ba3f7372bdf4aa45705 Mon Sep 17 00:00:00 2001
From: Alphons Joseph <93847055+Crazypersonalph@users.noreply.github.com>
Date: Tue, 10 Sep 2024 21:18:37 +0800
Subject: [PATCH] refactor (ui): change about page to icon next to what's new

---
 src/seqta/utils/listeners/MessageListener.ts       |  8 +-------
 src/svelte-interface/pages/settings.svelte         | 13 +++++++++++--
 src/svelte-interface/pages/settings/general.svelte | 11 -----------
 3 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/src/seqta/utils/listeners/MessageListener.ts b/src/seqta/utils/listeners/MessageListener.ts
index 63148831..5a820eff 100644
--- a/src/seqta/utils/listeners/MessageListener.ts
+++ b/src/seqta/utils/listeners/MessageListener.ts
@@ -1,6 +1,6 @@
 import browser from 'webextension-polyfill'
 
-import { closeSettings, MenuOptionsOpen, OpenMenuOptions, OpenWhatsNewPopup } from '../../../SEQTA';
+import { closeSettings, MenuOptionsOpen, OpenMenuOptions } from '../../../SEQTA';
 import { deleteTheme } from '@/seqta/ui/themes/deleteTheme';
 import { getAvailableThemes } from '@/seqta/ui/themes/getAvailableThemes';
 import { saveTheme } from '@/seqta/ui/themes/saveTheme';
@@ -73,12 +73,6 @@ export class MessageHandler {
           sendResponse(themes);
         });
         return true;
-  
-      case 'OpenChangelog':
-        OpenWhatsNewPopup();
-        closeSettings();
-        sendResponse({ status: 'success' });
-        break;
 
       case 'OpenThemeCreator':
         const themeID = request?.body?.themeID;
diff --git a/src/svelte-interface/pages/settings.svelte b/src/svelte-interface/pages/settings.svelte
index dde96d48..ba22bd2f 100644
--- a/src/svelte-interface/pages/settings.svelte
+++ b/src/svelte-interface/pages/settings.svelte
@@ -9,8 +9,16 @@
   import { onMount } from 'svelte'
   import { settingsState } from '@/seqta/utils/listeners/SettingsState'
 
+  import { closeSettings, OpenAboutPage, OpenWhatsNewPopup } from "@/SEQTA"
+
   const openChangelog = () => {
-    browser.runtime.sendMessage({ type: 'currentTab', info: 'OpenChangelog' });
+    OpenWhatsNewPopup();
+    closeSettings();
+  };
+
+  const openAbout = () => {
+    OpenAboutPage();
+    closeSettings();
   };
     
   let { standalone = false } = $props<{ standalone?: boolean }>();
@@ -28,7 +36,8 @@
     <div class="grid border-b border-b-zinc-200/40 place-items-center">
       <img src={browser.runtime.getURL('resources/icons/betterseqta-dark-full.png')} class="w-4/5 dark:hidden" alt="Light logo" />
       <img src={browser.runtime.getURL('resources/icons/betterseqta-light-full.png')} class="hidden w-4/5 dark:block" alt="Dark logo" />
-      <button onclick={openChangelog} class="absolute w-8 h-8 text-lg rounded-xl font-IconFamily top-1 right-1 bg-zinc-100 dark:bg-zinc-700"></button>
+      <button onclick={openChangelog} class="absolute w-8 h-8 text-lg rounded-xl font-IconFamily top-1 right-0 bg-zinc-100 dark:bg-zinc-700"></button>
+      <button onclick={openAbout} class="absolute w-8 h-8 text-lg rounded-xl font-IconFamily top-1 right-10 bg-zinc-100 dark:bg-zinc-700">ⓘ</button>
     </div>
 
     <TabbedContainer tabs={[
diff --git a/src/svelte-interface/pages/settings/general.svelte b/src/svelte-interface/pages/settings/general.svelte
index 4dfc6995..33804f76 100644
--- a/src/svelte-interface/pages/settings/general.svelte
+++ b/src/svelte-interface/pages/settings/general.svelte
@@ -8,7 +8,6 @@
   
   import type { SettingsList } from "@/svelte-interface/types/SettingsProps"
   import { settingsState } from "@/seqta/utils/listeners/SettingsState.ts"
-  import { closeSettings, OpenAboutPage } from "@/SEQTA"
 </script>
 
 {#snippet Setting({ title, description, Component, props }: SettingsList) }
@@ -91,16 +90,6 @@
         onChange: (isOn: boolean) => settingsState.lessonalert = isOn
       }
     },
-    {
-      title: "About BetterSEQTA+",
-      description: "Opens About page.",
-      id: 9,
-      Component: Button,
-      props: {
-        onClick: () => { OpenAboutPage(); closeSettings() },
-        text: "Open"
-      }
-    },
     {
       title: "BetterSEQTA+",
       description: "Enables BetterSEQTA+ features",