From 966b58b93242fed913c007584c0560310657a33c Mon Sep 17 00:00:00 2001 From: sethburkart123 Date: Tue, 10 Sep 2024 09:43:43 +1000 Subject: [PATCH] refactor(ui): extract about page opening to a direct function call --- src/seqta/utils/listeners/MessageListener.ts | 8 +------- src/svelte-interface/pages/settings/general.svelte | 3 ++- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/seqta/utils/listeners/MessageListener.ts b/src/seqta/utils/listeners/MessageListener.ts index 8e5364aa..63148831 100644 --- a/src/seqta/utils/listeners/MessageListener.ts +++ b/src/seqta/utils/listeners/MessageListener.ts @@ -1,6 +1,6 @@ import browser from 'webextension-polyfill' -import { closeSettings, MenuOptionsOpen, OpenAboutPage, OpenMenuOptions, OpenWhatsNewPopup } from '../../../SEQTA'; +import { closeSettings, MenuOptionsOpen, OpenMenuOptions, OpenWhatsNewPopup } from '../../../SEQTA'; import { deleteTheme } from '@/seqta/ui/themes/deleteTheme'; import { getAvailableThemes } from '@/seqta/ui/themes/getAvailableThemes'; import { saveTheme } from '@/seqta/ui/themes/saveTheme'; @@ -80,12 +80,6 @@ export class MessageHandler { sendResponse({ status: 'success' }); break; - case 'OpenAboutPage': - OpenAboutPage(); - closeSettings(); - sendResponse({ status: 'success' }); - break; - case 'OpenThemeCreator': const themeID = request?.body?.themeID; OpenThemeCreator( themeID ? themeID : '' ); diff --git a/src/svelte-interface/pages/settings/general.svelte b/src/svelte-interface/pages/settings/general.svelte index 81e53913..4dfc6995 100644 --- a/src/svelte-interface/pages/settings/general.svelte +++ b/src/svelte-interface/pages/settings/general.svelte @@ -8,6 +8,7 @@ import type { SettingsList } from "@/svelte-interface/types/SettingsProps" import { settingsState } from "@/seqta/utils/listeners/SettingsState.ts" + import { closeSettings, OpenAboutPage } from "@/SEQTA" {#snippet Setting({ title, description, Component, props }: SettingsList) } @@ -96,7 +97,7 @@ id: 9, Component: Button, props: { - onClick: () => browser.runtime.sendMessage({ type: 'currentTab', info: 'OpenAboutPage' }), + onClick: () => { OpenAboutPage(); closeSettings() }, text: "Open" } },