Merge pull request #1 from BetterSEQTA/main

Merge changes for testing PR

src/background.ts

@@ -100,10 +100,6 @@ const DefaultValues: SettingsState = {
   assessmentsAverage: true,
   defaultPage: "home",
   shortcuts: [
-    {
-      name: "YouTube",
-      enabled: false,
-    },
     {
       name: "Outlook",
       enabled: true,
@@ -112,42 +108,10 @@ const DefaultValues: SettingsState = {
       name: "Office",
       enabled: true,
     },
-    {
-      name: "Spotify",
-      enabled: false,
-    },
     {
       name: "Google",
       enabled: true,
     },
-    {
-      name: "DuckDuckGo",
-      enabled: false,
-    },
-    {
-      name: "Cool Math Games",
-      enabled: false,
-    },
-    {
-      name: "SACE",
-      enabled: false,
-    },
-    {
-      name: "Google Scholar",
-      enabled: false,
-    },
-    {
-      name: "Gmail",
-      enabled: false,
-    },
-    {
-      name: "Netflix",
-      enabled: false,
-    },
-    {
-      name: "Education Perfect",
-      enabled: false,
-    },
   ],
   customshortcuts: [],
   lettergrade: false,

src/interface/components/Switch.svelte

@@ -50,6 +50,6 @@
   }
 
   .dark .switch[data-ison="true"] {
-    @apply from-[#30D259]/50 to-[#30D259];
+    @apply from-[#30D259]/40 to-[#30D259];
   }
 </style>

src/interface/pages/settings/shortcuts.svelte

@@ -3,6 +3,7 @@
   import { settingsState } from "@/seqta/utils/listeners/SettingsState.ts"
   import Switch from "@/interface/components/Switch.svelte"
   import { onMount } from 'svelte';
+  import Shortcuts from "@/seqta/content/links.json"
 
   let isLoaded = $state(false);
 
@@ -21,10 +22,14 @@
     });
   });
 
-  const switchChange = (index: number) => {    
+  const switchChange = (shortcut: any) => {    
-    const updatedShortcuts = [...settingsState.shortcuts];
+    const value = $settingsState.shortcuts.find(s => s.name === shortcut);
-    updatedShortcuts[index].enabled = !updatedShortcuts[index].enabled;
+    if (value) {
-    settingsState.shortcuts = updatedShortcuts;
+      value.enabled = !value.enabled;
+      settingsState.shortcuts = settingsState.shortcuts;
+    } else {
+      settingsState.shortcuts = [...settingsState.shortcuts, { name: shortcut, enabled: true }];
+    }
   }
 
   let isFormVisible = $state(false);
@@ -65,15 +70,6 @@
   };
 </script>
 
-{#snippet Shortcuts([index, Shortcut]: [string, { name: string, enabled: boolean }]) }
-<div class="flex justify-between items-center px-4 py-3">
-  <div class="pr-4">
-    <h2 class="text-sm">{Shortcut.name}</h2>
-  </div>
-  <Switch state={Shortcut.enabled} onChange={() => switchChange(parseInt(index))} />
-</div>
-{/snippet}
-
 <div class="flex flex-col pt-4 divide-y divide-zinc-100 dark:divide-zinc-700">
   {#if isLoaded}
     <div>
@@ -136,8 +132,13 @@
       </MotionDiv>
     </div>
 
-    {#each Object.entries($settingsState.shortcuts) as shortcut}
+    {#each Object.entries(Shortcuts) as shortcut}
-      {@render Shortcuts(shortcut)}
+      <div class="flex justify-between items-center px-4 py-3">
+        <div class="pr-4">
+          <h2 class="text-sm">{shortcut[0]}</h2>
+        </div>
+        <Switch state={$settingsState.shortcuts.find(s => s.name === shortcut[0])?.enabled ?? false} onChange={() => switchChange(shortcut[0])} />
+      </div>
     {/each}
 
     <!-- Custom Shortcuts Section -->

src/plugins/built-in/globalSearch/src/indexing/jobs.ts

@@ -1,10 +1,10 @@
 import type { Job } from "./types";
 import { messagesJob } from "./jobs/messages";
-import { assessmentsJob } from "./jobs/assessments";
+import { notificationsJob } from "./jobs/notifications";
 import { forumsJob } from "./jobs/forums";
 
 export const jobs: Record<string, Job> = {
   messages: messagesJob,
-  assessments: assessmentsJob,
+  notifications: notificationsJob,
   forums: forumsJob,
 };

src/plugins/built-in/globalSearch/src/indexing/jobs/notifications.ts

@@ -27,8 +27,7 @@ interface AssessmentNotification {
 
 type Notification = MessageNotification | AssessmentNotification;
 
-/* ------------- Progress model ------------- */
+interface NotificationsProgress {
-interface AssessmentsProgress {
   lastTs: number; // ms since epoch of last processed notification
 }
 
@@ -108,14 +107,14 @@ const fetchAssessmentName = async (
 };
 
 /* ------------- Job ------------- */
-export const assessmentsJob: Job = {
+export const notificationsJob: Job = {
-  id: "assessments",
+  id: "notifications",
-  label: "Assessments",
+  label: "Notifications",
-  renderComponentId: "assessment",
+  renderComponentId: "notifications",
   frequency: { type: "expiry", afterMs: 15 * 60 * 1000 },
 
   run: async (ctx) => {
-    const progress = (await ctx.getProgress<AssessmentsProgress>()) ?? {
+    const progress = (await ctx.getProgress<NotificationsProgress>()) ?? {
       lastTs: 0,
     };
 
@@ -123,14 +122,14 @@ export const assessmentsJob: Job = {
     try {
       notifications = await fetchNotifications();
     } catch (e) {
-      console.error("[Assessments job] fetch failed:", e);
+      console.error("[Notifications job] fetch failed:", e);
       return [];
     }
 
     const notificationIsIndexed = async (id: string): Promise<boolean> => {
       const [inAssessments, inMessages] = await Promise.all([
         ctx
-          .getStoredItems("assessments")
+          .getStoredItems("notifications")
           .then((items) => items.some((i) => i.id === id)),
         ctx
           .getStoredItems("messages")

src/seqta/utils/listeners/StorageChanges.ts

@@ -70,14 +70,13 @@ export class StorageChangeHandler {
     oldValue: { enabled: boolean; name: string }[],
   ) {
     const addedShortcuts = newValue.filter((newItem: any) => {
-      const isAdded = oldValue.some((oldItem: any) => {
+      const wasDisabledAndNowEnabled = oldValue.some((oldItem: any) => {
-        const match = oldItem.name === newItem.name;
+        return oldItem.name === newItem.name && !oldItem.enabled && newItem.enabled;
-        const wasDisabled = !oldItem.enabled;
-        const isEnabled = newItem.enabled;
-        return match && wasDisabled && isEnabled;
       });
 
-      return isAdded;
+      const isNewShortcut = !oldValue.some((oldItem: any) => oldItem.name === newItem.name);
+
+      return (wasDisabledAndNowEnabled || isNewShortcut) && newItem.enabled;
     });
 
     const removedShortcuts = newValue.filter((newItem: any) => {